This behaves like the UNIX ls -d.
This should solve the use case of Bug #858; ls was never intended to
work that way before. Users can now chose between the two modes (with or
without -d).
With flake8, we can check for more issues and ignore those who are not
real issues.
This allowed me to find genuine errors in:
- modules/boursorama/pages/account_history.py
- modules/ing/pages/login.py
- weboob/tools/application/qt/qt.py
I left one in weboob/tools/browser/browser.py for the time being.
Some PEP8 fixes on other files.
Until now, ls discarded arguments.
ls = ls dir:
videoob> ls
~ (emissions) Emissions (canalplus)
~ (sport) Sport (canalplus)
~ (cinema) Cinema (canalplus)
~ (cesar-2012) Cesar 2012 (canalplus)
~ (series-fictions) Series / fictions (canalplus)
~ (du-hard-ou-du-cochon) Du hard ou du cochon (canalplus)
~ (divertissement) Divertissement (canalplus)
~ (canal-street) Canal street (canalplus)
~ (musique) Musique (canalplus)
~ (docus-infos) Docus / infos (canalplus)
videoob> ls sport
~ (emissions) Emissions (canalplus)
~ (sport) Sport (canalplus)
~ (cinema) Cinema (canalplus)
~ (cesar-2012) Cesar 2012 (canalplus)
~ (series-fictions) Series / fictions (canalplus)
~ (du-hard-ou-du-cochon) Du hard ou du cochon (canalplus)
~ (divertissement) Divertissement (canalplus)
~ (canal-street) Canal street (canalplus)
~ (musique) Musique (canalplus)
~ (docus-infos) Docus / infos (canalplus)
With this patch, we are now able to ls a dir without chdir into it.
For instance:
videoob> ls
~ (emissions) Emissions (canalplus)
~ (sport) Sport (canalplus)
~ (cinema) Cinema (canalplus)
~ (cesar-2012) Cesar 2012 (canalplus)
~ (series-fictions) Series / fictions (canalplus)
~ (du-hard-ou-du-cochon) Du hard ou du cochon (canalplus)
~ (divertissement) Divertissement (canalplus)
~ (canal-street) Canal street (canalplus)
~ (musique) Musique (canalplus)
~ (docus-infos) Docus / infos (canalplus)
videoob> ls sport
~ (les-incontournables) Les incontournables (canalplus)
~ (les-plus-recentes) Les plus recentes (canalplus)
~ (les-plus-vues) Les plus vues (canalplus)
~ (tout-le-football) Tout le football (canalplus)
~ (tout-le-rugby) Tout le rugby (canalplus)
~ (tout-le-basket) Tout le basket (canalplus)
~ (tout-le-tennis-golf) Tout le tennis / golf (canalplus)
~ (autres-sports-home-sport) Autres sports - home sport (canalplus)
~ (les-emissions-sport) Les emissions sport (canalplus)
videoob> ls
~ (emissions) Emissions (canalplus)
~ (sport) Sport (canalplus)
~ (cinema) Cinema (canalplus)
~ (cesar-2012) Cesar 2012 (canalplus)
~ (series-fictions) Series / fictions (canalplus)
~ (du-hard-ou-du-cochon) Du hard ou du cochon (canalplus)
~ (divertissement) Divertissement (canalplus)
~ (canal-street) Canal street (canalplus)
~ (musique) Musique (canalplus)
~ (docus-infos) Docus / infos (canalplus)
Signed-off-by: theo <theocrite@theocrite.org>
I used autopep8 on some files and did carefully check the changes.
I ignored E501,E302,E231,E225,E222,E221,E241,E203 in my search, and at
least E501 on any autopep8 run.
Other style fixes not related to PEP8:
* Only use new-style classes. I don't think the usage of old-style
classes was voluntary. Old-style classes are removed in Python 3.
* Convert an if/else to a one-liner in mediawiki, change docstring style
change to a comment something that wasn't really appropriate for a
docstring.
* Unneeded first if condition in meteofrance
Don't force objects to have an id, especially since that id was
incorrect. "plap/plop" would have the same id as "plop", i.e. "plop".
We don't rely on the id for handling Collections anymore.
Change to use more unique property names.
Change the display, instead of using '*', we use '~', and there is no
"Collection" header anymore.
Updated formatters could use that way of showing the object is also a
collection too.
refs #774
Handle and use exceptions.
An example is provided with the redmine backend (not very useful
though). If you cd into the project title instead of the id, it is
accepted and the path is corrected.
* Create a get_collection method similar to get_* methods for objects.
* Fix title initialization of a collection
* Remove the hack were both id and title were allowed when CDing.
That hack only worked with the canalplus module, and failed with
others like redmine (but they still showed in suggestions).
Moreover, the canalplus module now has friendlier IDs
so this is not really needed anymore.
* Allow backends to tell if a path is valid or not.
For instance, it now allows to cd in a Redmine project with no issues
in it. It also won't display "404" for invalid project IDs.
By default, we still use the unreliable method of checking there is at
least one result in iter_resources().
* Fix cd completion to work with unicode strings (all strings after an
unicode string were ignored!)
* Do not suggest '..' when completing cd in the root
refs #774
* Remove callbacks in Collection object
Make Collection a "dumb" object (and also a base object,
though it isn't very useful for now)
* Rename Path to WorkingPath, because it is more about managing state
than being a single path.
* Rewrite almost all WorkingPath, because the code was overly
complicated for no reason (I tried some special cases and it turned
out that fromstring didn't handle them, and that the
quote-escape-unquote was just unecessary). I also rewrote it to be
more pythonic (no more lambdas and maps) and added tests.
* Require the full split path when creating a Collection. Because, come to
think of it, an object needs an unique identifier; in the case of
Collections, it is the full path, not only its last part.
I might even replace the id by the full split path in the future.
* There is now only one way to get items of a Collection: calling
iter_resources().
* Rewrite flatten_resources to iter_resources_flat(), which just calls
iter_resources() recursively.
* Rewrite the collection part of the canalplus module. There is no more
callback or a page calling the browser to check another page!
The logic is only in iter_resources().
The resulting code is not very pretty, but it should get better.
As a bonus, avoid to reload the main XML file when we already have it
open.
* change_path() now expects a split path and not a string.
* up/home special cases for "cd" are handled in the same place, and
store the previous place properly (but are not yet exploitable by
an user command).
This is a big commit but it would be hard to split it in *working*
commits.
If you read this entire commit message, I will buy you a beer.
refs #774fixes#773
