With flake8, we can check for more issues and ignore those who are not
real issues.
This allowed me to find genuine errors in:
- modules/boursorama/pages/account_history.py
- modules/ing/pages/login.py
- weboob/tools/application/qt/qt.py
I left one in weboob/tools/browser/browser.py for the time being.
Some PEP8 fixes on other files.
FIP now uses the same website as most Radio France radios.
As a consequence, it is able to support CapVideo.
There are a few differences between FIP and the other radios, but this
still allowed for less code, and the code should be more robust for
every radio.
* Remove callbacks in Collection object
Make Collection a "dumb" object (and also a base object,
though it isn't very useful for now)
* Rename Path to WorkingPath, because it is more about managing state
than being a single path.
* Rewrite almost all WorkingPath, because the code was overly
complicated for no reason (I tried some special cases and it turned
out that fromstring didn't handle them, and that the
quote-escape-unquote was just unecessary). I also rewrote it to be
more pythonic (no more lambdas and maps) and added tests.
* Require the full split path when creating a Collection. Because, come to
think of it, an object needs an unique identifier; in the case of
Collections, it is the full path, not only its last part.
I might even replace the id by the full split path in the future.
* There is now only one way to get items of a Collection: calling
iter_resources().
* Rewrite flatten_resources to iter_resources_flat(), which just calls
iter_resources() recursively.
* Rewrite the collection part of the canalplus module. There is no more
callback or a page calling the browser to check another page!
The logic is only in iter_resources().
The resulting code is not very pretty, but it should get better.
As a bonus, avoid to reload the main XML file when we already have it
open.
* change_path() now expects a split path and not a string.
* up/home special cases for "cd" are handled in the same place, and
store the previous place properly (but are not yet exploitable by
an user command).
This is a big commit but it would be hard to split it in *working*
commits.
If you read this entire commit message, I will buy you a beer.
refs #774fixes#773
* Make the declaration of fct and it in the constructor Collection,
instead of adding them from the outside
* Add a function to flatten a list containing collection (solves the
radioob search crash)
* Better display of collections in the "ls" command (and display both id
and title)
* The "cd" command goes to the root of the path (like the UNIX cd)
* Move the Video object of canalplus in a correct path
* Make Collection iterable
* Add comments to CapCollection
* Cache the result of fct in a Collection; it is only called once
* CollectionNotFound errors can be more explicit by providing a path
* Require utf-8 in collection paths
* Code cleanups
Rationale:
* 43 stations for a radio not many people care about
* It's still available by cd francebleu; ls
* The fact that it exists is displayed on the 'root' ls (though poorly,
but it's CapCollection's/ReplApplication fault).
* Support for France Inter and Le Mouv', and many new radios.
* For some radios only, the current emission is fetched. Previously it was
wrong for all two of them.
* New icon.
* Fix typo in LICENSE.
* Fix code style.
* Use fillobj() instead of duplicate code.
* Since there is not much left of the originals, I made myself the maintainer.
