Most backends don't set it nb_messages and no application used it.
No backends set nb_unread and only one application tried to use it.
This should help avoid useless fillobj() calls in some cases.
fixes#827
It is unused, and no backend implemented it — so it was wrong to have it
in the function signature.
It also does not seem very helpful, we have get_threads() if we want to
do something advanced with treads.
fixes#825
There is now a "latest" collection (or "latest_nsfw").
The feature didn't look much used, since it didn't work on many
backends.
Using collections will make it easy to support other things
like most viewed, featured, etc.
As a bonus, I added tests for every backend with the feature.
I used autopep8 on some files and did carefully check the changes.
I ignored E501,E302,E231,E225,E222,E221,E241,E203 in my search, and at
least E501 on any autopep8 run.
Other style fixes not related to PEP8:
* Only use new-style classes. I don't think the usage of old-style
classes was voluntary. Old-style classes are removed in Python 3.
* Convert an if/else to a one-liner in mediawiki, change docstring style
change to a comment something that wasn't really appropriate for a
docstring.
* Unneeded first if condition in meteofrance
Don't force objects to have an id, especially since that id was
incorrect. "plap/plop" would have the same id as "plop", i.e. "plop".
We don't rely on the id for handling Collections anymore.
Change to use more unique property names.
Change the display, instead of using '*', we use '~', and there is no
"Collection" header anymore.
Updated formatters could use that way of showing the object is also a
collection too.
refs #774
Handle and use exceptions.
An example is provided with the redmine backend (not very useful
though). If you cd into the project title instead of the id, it is
accepted and the path is corrected.
* Create a get_collection method similar to get_* methods for objects.
* Fix title initialization of a collection
* Remove the hack were both id and title were allowed when CDing.
That hack only worked with the canalplus module, and failed with
others like redmine (but they still showed in suggestions).
Moreover, the canalplus module now has friendlier IDs
so this is not really needed anymore.
* Allow backends to tell if a path is valid or not.
For instance, it now allows to cd in a Redmine project with no issues
in it. It also won't display "404" for invalid project IDs.
By default, we still use the unreliable method of checking there is at
least one result in iter_resources().
* Fix cd completion to work with unicode strings (all strings after an
unicode string were ignored!)
* Do not suggest '..' when completing cd in the root
refs #774
* Remove callbacks in Collection object
Make Collection a "dumb" object (and also a base object,
though it isn't very useful for now)
* Rename Path to WorkingPath, because it is more about managing state
than being a single path.
* Rewrite almost all WorkingPath, because the code was overly
complicated for no reason (I tried some special cases and it turned
out that fromstring didn't handle them, and that the
quote-escape-unquote was just unecessary). I also rewrote it to be
more pythonic (no more lambdas and maps) and added tests.
* Require the full split path when creating a Collection. Because, come to
think of it, an object needs an unique identifier; in the case of
Collections, it is the full path, not only its last part.
I might even replace the id by the full split path in the future.
* There is now only one way to get items of a Collection: calling
iter_resources().
* Rewrite flatten_resources to iter_resources_flat(), which just calls
iter_resources() recursively.
* Rewrite the collection part of the canalplus module. There is no more
callback or a page calling the browser to check another page!
The logic is only in iter_resources().
The resulting code is not very pretty, but it should get better.
As a bonus, avoid to reload the main XML file when we already have it
open.
* change_path() now expects a split path and not a string.
* up/home special cases for "cd" are handled in the same place, and
store the previous place properly (but are not yet exploitable by
an user command).
This is a big commit but it would be hard to split it in *working*
commits.
If you read this entire commit message, I will buy you a beer.
refs #774fixes#773
This method can be used to fill all empty fields with the same value.
A field is empty when is value is None, NotLoaded or NotAvailable.
Example:
# It will be impossible to get all empty fields, except
# of 'url' (with a call to fillobj())
video.set_empty_fields(NotAvailable, ('url',))
Types were taken from KMyMoney, which is for personal tracking, however
some types had no use (cash not something the bank can provide,
maybe credit card but it is usually the "coming" field for us).
Sources: https://en.wikipedia.org/wiki/Bank_account (but not focused on
personal banking) and it's French translation which was more interesting.
Other websites for American and Australian banking almost always mentioned three
accounts: checking/current, savings/deposits, term/fixed deposits.
And some code refactoring.
Collections are not stored in replapplication.objects anymore, but in
replapplication.collections. This fixes the IDs issue. There was no gain
from storing them in objects.
Completion right after cd should be faster (and should always have been
like that, it was pretty much a bug).
The display of do_ls() should be much clearer. Collections are always at
the end, have ids/title/backend like objects (but using a formatter
would be better than my current hack).
There are still many issues with the current implementation.
refs #774closes#785
While this changes constants names, I think it is important as "accused" is
complely wrong. E-mails use the term "Read-receipts" so I chose
to go with RECEIVED.
* Make the declaration of fct and it in the constructor Collection,
instead of adding them from the outside
* Add a function to flatten a list containing collection (solves the
radioob search crash)
* Better display of collections in the "ls" command (and display both id
and title)
* The "cd" command goes to the root of the path (like the UNIX cd)
* Move the Video object of canalplus in a correct path
* Make Collection iterable
* Add comments to CapCollection
* Cache the result of fct in a Collection; it is only called once
* CollectionNotFound errors can be more explicit by providing a path
* Require utf-8 in collection paths
* Code cleanups
