From ea030bf6abd6fc0edc047665c3e9ac51aa76bf08 Mon Sep 17 00:00:00 2001 From: Baptiste Delpey Date: Tue, 3 Feb 2015 10:59:46 +0100 Subject: [PATCH] NotImplemented exception for history on asv and clean code --- modules/ing/browser.py | 2 +- modules/ing/pages/accounts_list.py | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/modules/ing/browser.py b/modules/ing/browser.py index 49200311..2dcb64ea 100644 --- a/modules/ing/browser.py +++ b/modules/ing/browser.py @@ -263,7 +263,7 @@ class IngBrowser(LoginBrowser): return self.page.iter_history() else: # No history for ASV accounts. - return iter([]) + raise NotImplementedError() ############# CapBill ############# @need_login diff --git a/modules/ing/pages/accounts_list.py b/modules/ing/pages/accounts_list.py index 7300e01f..3a0e8a9b 100644 --- a/modules/ing/pages/accounts_list.py +++ b/modules/ing/pages/accounts_list.py @@ -170,10 +170,6 @@ class AccountsList(LoggedPage, HTMLPage): item_xpath = '//table' def get_history_jid(self): - if self.is_asv: - # Assurance Vie, we do not support this kind of account. - return None - span = Attr('//span[starts-with(@id, "index:j_id")]', 'id')(self.doc) jid = span.split(':')[1] return jid