cleanup and update AUTHORS

AUTHORS

@@ -53,6 +53,9 @@ Xavier Guerrin <xavier@tuxfamily.org>
 Gabriel Kerneis <kerneis@pps.jussieu.fr>
         * Boursorama module maintainer.
 
+Kevin Pouget <kevin.pouget@st.com>
+        * CreditCooperatif module maintainer.
+
 Gilles Quenot <gilles.quenot@gmail.com>
         * Fortuneo module maintainer.
 

modules/creditcooperatif/backend.py

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-# Copyright(C) 2012 Kevin Pouget, based on Romain Bignon work
+# Copyright(C) 2012 Kevin Pouget
 #
 # This file is part of weboob.
 #
@@ -20,7 +20,6 @@
 
 from weboob.capabilities.bank import ICapBank, AccountNotFound
 from weboob.tools.backend import BaseBackend, BackendConfig
-from weboob.tools.ordereddict import OrderedDict
 from weboob.tools.value import ValueBackendPassword, Value
 
 from .browser import CreditCooperatif
@@ -40,14 +39,14 @@ class CreditCooperatifBackend(BaseBackend, ICapBank):
                  "strong": "Sesame"}
     CONFIG = BackendConfig(Value('auth_type',  label='Authentication type', choices=auth_type, default="strong"),
                            ValueBackendPassword('login', label='Account ID', masked=False),
-                           ValueBackendPassword('pin', label='One time pin'))
+                           ValueBackendPassword('password', label='Password or one time pin'))
 
     BROWSER = CreditCooperatif
 
     def create_default_browser(self):
         return self.create_browser(self.config['login'].get(),
-                                   self.config['pin'].get(),
-                                   self.config['auth_type'].get() == "strong")
+                                   self.config['password'].get(),
+                                   strong_auth=self.config['auth_type'].get() == "strong")
 
     def iter_accounts(self):
         with self.browser:

modules/creditcooperatif/browser.py

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-# Copyright(C) 2012 Romain Bignon
+# Copyright(C) 2012 Kevin Pouget
 #
 # This file is part of weboob.
 #
@@ -17,9 +17,6 @@
 # You should have received a copy of the GNU Affero General Public License
 # along with weboob. If not, see <http://www.gnu.org/licenses/>.
 
-
-import urllib
-
 from weboob.tools.browser import BaseBrowser, BrowserIncorrectPassword
 
 from .pages import LoginPage, AccountsPage, TransactionsPage, ComingTransactionsPage
@@ -40,9 +37,8 @@ class CreditCooperatif(BaseBrowser):
             }
 
     def __init__(self, *args, **kwargs):
-        #catch and remove the third/last arg
-        self.strong_auth = args[-1]
-        BaseBrowser.__init__(self, *args[:-1], **kwargs)
+        self.strong_auth = kwargs.pop('strong_auth', False)
+        BaseBrowser.__init__(self, *args, **kwargs)
 
     def home(self):
         self.location("/banque/sso/")

modules/creditcooperatif/pages.py

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-# Copyright(C) 2012 Kevin Pouget, based on Romain Bignon work
+# Copyright(C) 2012 Kevin Pouget
 #
 # This file is part of weboob.
 #
@@ -18,9 +18,9 @@
 # along with weboob. If not, see <http://www.gnu.org/licenses/>.
 
 
-from urlparse import urlsplit, parse_qsl
 from decimal import Decimal
 import re
+import time
 
 from weboob.tools.browser import BasePage
 from weboob.capabilities.bank import Account
@@ -156,7 +156,6 @@ class ComingTransactionsPage(BasePage):
                 #date is 'JJ/MM'. add '/YYYY'
                 date += comment[comment.rindex("/"):]
             else:
-                import time
                 date += "/%d" % time.localtime().tm_year
 
 

modules/creditcooperatif/test.py

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 
-# Copyright(C) 2012 Kevin Pouget, based on Romain Bignon
+# Copyright(C) 2012 Kevin Pouget
 #
 # This file is part of weboob.
 #