nojhan/weboob-devel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove nb_unread/nb_messages in CapMessages

Browse source 
Most backends don't set it nb_messages and no application used it.
No backends set nb_unread and only one application tried to use it.

This should help avoid useless fillobj() calls in some cases.

fixes #827
This commit is contained in:
Laurent Bachelier 2012-03-22 19:25:26 +01:00 • committed by Romain Bignon
commit ba5949cd22
5 changed files with 4 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

12
weboob/applications/boobmsg/boobmsg.py
View file

@ -96,19 +96,15 @@ class MessagesListFormatter(IFormatter):
def format_dict_thread(self, item):
self.count += 1
if item['nb_unread'] and item['nb_unread'] > 0:
unread = '[N]'
else:
unread = ' '
if self.interactive:
backend = item['id'].split('@', 1)[1]
result = u'%s* (%d) %s %s (%s)%s' % (self.BOLD,
self.count, unread,
result = u'%s* (%d) %s (%s)%s' % (self.BOLD,
self.count,
item['title'], backend,
self.NC)
else:
result = u'%s* (%s) %s %s%s' % (self.BOLD, item['id'],
unread, item['title'],
result = u'%s* (%s) %s%s' % (self.BOLD, item['id'],
item['title'],
self.NC)
if item['date']:
result += u'\n %s' % item['date']

2
weboob/capabilities/messages.py
View file

@ -105,8 +105,6 @@ class Thread(CapBaseObject):
self.add_field('root', Message)
self.add_field('title', basestring)
self.add_field('date', (datetime.datetime, datetime.date))
self.add_field('nb_messages', int)
self.add_field('nb_unread', int)
self.add_field('flags', int, self.IS_THREADS)
def iter_all_messages(self):