From 73b6b1e655ee0b6aecd4e05b0c770f25ed9165ab Mon Sep 17 00:00:00 2001 From: Romain Bignon Date: Mon, 7 Mar 2011 08:47:17 +0100 Subject: [PATCH] new method get_comment --- weboob/backends/dlfp/browser.py | 19 ++++++++++++------- weboob/backends/dlfp/pages/news.py | 2 +- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/weboob/backends/dlfp/browser.py b/weboob/backends/dlfp/browser.py index d716800c..d868f6f0 100644 --- a/weboob/backends/dlfp/browser.py +++ b/weboob/backends/dlfp/browser.py @@ -103,13 +103,7 @@ class DLFP(BaseBrowser): def close_session(self): self.openurl('/compte/deconnexion') - def plusse(self, url): - return self.relevance(url, 'for') - - def moinse(self, url): - return self.relevance(url, 'against') - - def relevance(self, url, what): + def get_comment(self, url): self.location(url) comment = None @@ -119,6 +113,17 @@ class DLFP(BaseBrowser): ignored, id = url.rsplit('#comment-', 1) comment = self.page.get_comment(int(id)) + return comment + + def plusse(self, url): + return self.relevance(url, 'for') + + def moinse(self, url): + return self.relevance(url, 'against') + + def relevance(self, url, what): + comment = self.get_comment(url) + if comment is None: raise ValueError('The given URL isn\'t a comment.') diff --git a/weboob/backends/dlfp/pages/news.py b/weboob/backends/dlfp/pages/news.py index 54395554..a6231276 100644 --- a/weboob/backends/dlfp/pages/news.py +++ b/weboob/backends/dlfp/pages/news.py @@ -83,7 +83,7 @@ class Article(object): self.date = None self.comments = [] - if not tree: + if tree is None: return header = tree.find('header')