From 4f897a8675ecff1a7b1dfe82598398bd0a9e6c1d Mon Sep 17 00:00:00 2001 From: Laurent Bachelier Date: Sat, 11 Oct 2014 01:46:25 +0200 Subject: [PATCH] pep8: Fix object comparisons --- modules/aum/optim/queries_queue.py | 2 +- weboob/applications/weboobcfg/weboobcfg.py | 2 +- weboob/tools/application/base.py | 2 +- weboob/tools/application/media_player.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/aum/optim/queries_queue.py b/modules/aum/optim/queries_queue.py index b2cbea84..357d8fa1 100644 --- a/modules/aum/optim/queries_queue.py +++ b/modules/aum/optim/queries_queue.py @@ -96,7 +96,7 @@ class QueriesQueue(Optimization): except BrowserUnavailable: # We consider this profil hasn't been [correctly] analysed - if not id is None: + if id is not None: self.queue.append((priority, id)) finally: self.save() diff --git a/weboob/applications/weboobcfg/weboobcfg.py b/weboob/applications/weboobcfg/weboobcfg.py index 0a1ea0ba..742ee143 100644 --- a/weboob/applications/weboobcfg/weboobcfg.py +++ b/weboob/applications/weboobcfg/weboobcfg.py @@ -229,7 +229,7 @@ class WeboobCfg(ReplApplication): first = True for key, field in module.config.iteritems(): value = field.label - if not field.default is None: + if field.default is not None: value += ' (default: %s)' % field.default if first: print('| | ') diff --git a/weboob/tools/application/base.py b/weboob/tools/application/base.py index d7eb3c13..8fe2310e 100644 --- a/weboob/tools/application/base.py +++ b/weboob/tools/application/base.py @@ -353,7 +353,7 @@ class Application(object): if self.options.shell_completion: items = set() for option in self._parser.option_list: - if not option.help is optparse.SUPPRESS_HELP: + if option.help is not optparse.SUPPRESS_HELP: items.update(str(option).split('/')) items.update(self._get_completions()) print(' '.join(items)) diff --git a/weboob/tools/application/media_player.py b/weboob/tools/application/media_player.py index 0e916c89..99b0f151 100644 --- a/weboob/tools/application/media_player.py +++ b/weboob/tools/application/media_player.py @@ -95,7 +95,7 @@ class MediaPlayer(object): Play media.url with the media player. """ # if flag play_proxy... - if hasattr(media, '_play_proxy') and media._play_proxy == True: + if hasattr(media, '_play_proxy') and media._play_proxy is True: # use urllib2 to handle redirect and cookies self._play_proxy(media, player_name, args) return None