nojhan/weboob-devel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

github: don't fetch comments when iterating issues

Browse source
This commit is contained in:
Vincent A 2013-11-02 12:25:12 +01:00
commit 3f8169a672
2 changed files with 16 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
modules/github/browser.py
View file

@ -112,10 +112,7 @@ class GithubBrowser(BaseBrowser):
d['version'] = json['milestone']
else:
d['version'] = None
if json['comments'] > 0:
d['comments'] = list(self.get_comments(project_id, issue_number))
else:
d['comments'] = []
d['has_comments'] = (json['comments'] > 0)
d['attachments'] = list(self._extract_attachments(d['body']))
# TODO fetch other updates?
@ -125,7 +122,7 @@ class GithubBrowser(BaseBrowser):
for jmilestone in self.do_get('https://api.github.com/repos/%s/milestones' % project_id):
yield {'id': jmilestone['number'], 'name': jmilestone['title']}
def get_comments(self, project_id, issue_number):
def iter_comments(self, project_id, issue_number):
json = self.do_get('https://api.github.com/repos/%s/issues/%s/comments' % (project_id, issue_number))
for jcomment in json:
d = {'id': jcomment['id'], 'message': jcomment['body'], 'author': jcomment['user']['login'], 'date': parse_date(jcomment['created_at'])}