nojhan/weboob-devel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Centralize "empty" comparisons

Browse source 
And always use "is" instead of "==".
This commit is contained in:
Laurent Bachelier 2012-03-27 12:08:33 +02:00
commit 3b2bafdf12
3 changed files with 23 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

6
weboob/applications/videoob/videoob.py
View file

@ -24,7 +24,7 @@ import sys
import os
from weboob.capabilities.video import ICapVideo, BaseVideo
from weboob.capabilities.base import NotLoaded, NotAvailable
from weboob.capabilities.base import empty
from weboob.tools.application.repl import ReplApplication
from weboob.tools.application.media_player import InvalidMediaPlayer, MediaPlayer, MediaPlayerNotFound
from weboob.tools.application.formatters.iformatter import IFormatter
@ -49,9 +49,9 @@ class VideoListFormatter(IFormatter):
else:
result = u'%s* (%s) %s%s\n' % (self.BOLD, item['id'], item['title'], self.NC)
result += ' %s' % (item['duration'] if item['duration'] else item['date'])
if item['author'] not in (NotLoaded, NotAvailable, None):
if not empty(item['author']):
result += ' - %s' % item['author']
if item['rating'] not in (NotLoaded, NotAvailable, None):
if not empty(item['rating']):
result += u' (%s/%s)' % (item['rating'], item['rating_max'])
return result