nojhan/weboob-devel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Warn when implicit conversions happen

Browse source 
To display them, you can use the python -W argument
or the PYTHONWARNINGS environment variable.
Maybe debug mode should display them.
This commit is contained in:
Laurent Bachelier 2012-03-26 23:34:23 +02:00
commit 331b580fb8
1 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
weboob/capabilities/base.py
View file

@ -18,6 +18,7 @@
# along with weboob. If not, see <http://www.gnu.org/licenses/>. # along with weboob. If not, see <http://www.gnu.org/licenses/>.
import warnings
import datetime import datetime
from dateutil.parser import parse as parse_dt from dateutil.parser import parse as parse_dt
from copy import deepcopy from copy import deepcopy
@ -44,6 +45,12 @@ class FieldNotFound(Exception):
Exception.__init__(self, Exception.__init__(self,
u'Field "%s" not found for object %s' % (field, obj)) u'Field "%s" not found for object %s' % (field, obj))
class ConversionWarning(UserWarning):
"""
A field's type was changed when setting it.
Ideally, the module should use the right type before setting it.
"""
pass
class NotAvailableMeta(type): class NotAvailableMeta(type):
def __str__(self): def __str__(self):
@ -316,7 +323,12 @@ class CapBaseObject(object):
if value not in (NotLoaded, NotAvailable, None): if value not in (NotLoaded, NotAvailable, None):
try: try:
# Try to convert value to the wanted one. # Try to convert value to the wanted one.
value = attr.convert(value) nvalue = attr.convert(value)
# If the value was converted
if nvalue is not value:
warnings.warn('Value %s was converted from %s to %s' %
(name, type(value), type(nvalue)), ConversionWarning, stacklevel=2)
value = nvalue
except Exception: except Exception:
# error during conversion, it will probably not # error during conversion, it will probably not
# match the wanted following types, so we'll # match the wanted following types, so we'll