nojhan/smem
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[PATCH] invalid "-K" value cause smem ended with IndexError exception

Browse source 
I do "smem -w -K a.txt -R 2048M" and got following error:
zhichyu@w-shpd-zcyu:~/sftw4ubuntu$ smem-0.1/smem -w -K a.txt -R 2048M
size: 'a.txt': No such file
Traceback (most recent call last):
  File "smem-0.1/smem", line 607, in <module>
    showsystem()
  File "smem-0.1/smem", line 361, in showsystem
    k = kernelsize()
  File "smem-0.1/smem", line 77, in kernelsize
    d = os.popen("size %s" % options.kernel).readlines()[1]
IndexError: list index out of range

The root cause is that os.popen("size a.txt") returns only one line.
If the user provides an invalid kernel image file path, I think it's
better to assume the image size is zero than raise an exception.
This commit is contained in:
??? 2009-05-14 22:22:44 -05:00
commit 04b9f552f4
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
smem
View file

@ -83,8 +83,11 @@ _kernelsize = 0
def kernelsize(): def kernelsize():
global _kernelsize global _kernelsize
if not _kernelsize and options.kernel: if not _kernelsize and options.kernel:
try:
d = os.popen("size %s" % options.kernel).readlines()[1] d = os.popen("size %s" % options.kernel).readlines()[1]
_kernelsize = int(d.split()[3]) / 1024 _kernelsize = int(d.split()[3]) / 1024
except:
pass
return _kernelsize return _kernelsize
def pidmaps(pid): def pidmaps(pid):