From 379302b72e233eca35856a4b96a57aa0e0a409b5 Mon Sep 17 00:00:00 2001
From: nojhan <nojhan@nojhan.net>
Date: Tue, 23 Aug 2022 12:18:25 +0200
Subject: [PATCH] refactor(dotmatrix): avoid subshell

---
 themes/dotmatrix/dotmatrix.theme | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/themes/dotmatrix/dotmatrix.theme b/themes/dotmatrix/dotmatrix.theme
index a7c7168..668a4a4 100644
--- a/themes/dotmatrix/dotmatrix.theme
+++ b/themes/dotmatrix/dotmatrix.theme
@@ -151,9 +151,16 @@ _lp_dotmatrix_theme_activate() {
         DOTMATRIX_SPACE_FIELD=${DOTMATRIX_SPACE_FIELD:-""}
         DOTMATRIX_SPACE_LINE=${DOTMATRIX_SPACE_LINE:-" "}
     else
-        # FIXME avoid subshells
-        DOTMATRIX_SPACE_VOID=$(printf '%0.s ' $(seq 1 ${DOTMATRIX_SPACED})) # Regular space
-        DOTMATRIX_SPACE_FILL=$(printf '%0.s█' $(seq 1 ${DOTMATRIX_SPACED})) # Inverted space
+        local n="${DOTMATRIX_SPACED:-1}"
+        [[ $n -lt 0 ]] && n=1
+        local i
+        DOTMATRIX_SPACE_VOID=""
+        DOTMATRIX_SPACE_FILL=""
+        for ((i=0; i < n; i++)); do
+            DOTMATRIX_SPACE_VOID+=" " # Regular space
+            DOTMATRIX_SPACE_FILL+="█" # Inverted space
+        done
+
         DOTMATRIX_SPACE_PATH=${DOTMATRIX_SPACE_PATH:-"${DOTMATRIX_SPACE_VOID}"}
         DOTMATRIX_SPACE_FIELD=${DOTMATRIX_SPACE_FIELD:-""}
         DOTMATRIX_SPACE_LINE=${DOTMATRIX_SPACE_LINE:-""}